umamaheswararao commented on a change in pull request #3089:
URL: https://github.com/apache/ozone/pull/3089#discussion_r808177442



##########
File path: hadoop-ozone/dist/src/main/smoketest/ec/basic.robot
##########
@@ -38,7 +38,7 @@ Prepare For Tests
 Test Bucket Creation
     ${result} =     Execute             ozone sh volume create /${prefix}vol1
                     Should not contain  ${result}       Failed

Review comment:
       @kaijchen, Thanks for proving the details. I am not sure I fully get it 
here, but here is my another question to get it clarified:
   What if you don't pass ratis option here in the below line?
   ${result} =     Execute             ozone sh bucket create --replication 3 
--type RATIS /${prefix}vol1/${prefix}ratis
   
   Does this still create ratis key? I understand you already added a test with 
default. If we remove the options above, this should also be like default. But 
you are just testing these options as well. Is this correct?  ( I am not very 
good in understanding these script based tests yet. )
   
   I am trying to make sure the behavior is same as expected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to