kaijchen commented on a change in pull request #3089:
URL: https://github.com/apache/ozone/pull/3089#discussion_r808614039



##########
File path: hadoop-ozone/dist/src/main/smoketest/ec/basic.robot
##########
@@ -38,7 +38,7 @@ Prepare For Tests
 Test Bucket Creation
     ${result} =     Execute             ozone sh volume create /${prefix}vol1
                     Should not contain  ${result}       Failed

Review comment:
       If `--replication 3 --type RATIS` is missing here, the bucket-level 
replicationConfig will be `null`. When creating a key in this bucket, 
cluster-level config will be used, it will still create RATIS key because 
cluster-level config defaults to RATIS.
   If we change the cluster-level config by setting 
`ozone.server.default.replication = rs-3-2-1024k` and 
`ozone.server.default.replication.type = EC`. After OM restart, EC keys will be 
created by default in buckets without replication config.
   
   There will be 3 types of bucket after this change,
   
   | bucket type | bucket replicationConfig | cluster replicationConfig |
   | --- | --- | --- |
   | default | null | used |
   | ratis | ratis | ignored |
   | ec | ec | ignored |
    




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to