hanishakoneru commented on a change in pull request #2953:
URL: https://github.com/apache/ozone/pull/2953#discussion_r813281647
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
##########
@@ -1926,7 +1926,6 @@ public void stop() {
if (omSnapshotProvider != null) {
omSnapshotProvider.stop();
}
- omState = State.STOPPED;
Review comment:
I think it is duplication and can be removed.
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java
##########
@@ -337,7 +337,7 @@ void reloadSCMState()
public void shutdown() throws IOException {
if (ratisServer != null) {
ratisServer.stop();
- ratisServer.getSCMStateMachine().close();
+ ratisServer.getSCMStateMachine().stop();
Review comment:
SCMStateMachine#stop() will not terminate the service.
Is the idea behind changing from close() to stop() here that the process
should be terminated after all the services are stopped? If yes,
StorageContainerManager#stop() which calls this SCMHAManager#shutdown() does
not terminate the SCM process after shutdown. So the SCM process will not
terminate though its services have been shutdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
