hanishakoneru commented on a change in pull request #2953:
URL: https://github.com/apache/ozone/pull/2953#discussion_r822237877
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManagerImpl.java
##########
@@ -337,7 +337,7 @@ void reloadSCMState()
public void shutdown() throws IOException {
if (ratisServer != null) {
ratisServer.stop();
- ratisServer.getSCMStateMachine().close();
+ ratisServer.getSCMStateMachine().stop();
Review comment:
Then shouldn't the terminate be called after all the services are
stopped in StorageContainerManager. Wouldn't that be the right place to call
terminate?
_BackgroundPipelineCreator.stop()_ will be called when _PipelineManager_ is
closed in _StorageContainerManager_ (line 1523). _SCMMetadataStore_ is stopped
after _PipelineManager_ is closed and so it will not be stopped properly.
Please let me know if I am missing something here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
