smengcl commented on a change in pull request #3051:
URL: https://github.com/apache/ozone/pull/3051#discussion_r814107280
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMultiTenantManagerImpl.java
##########
@@ -374,10 +374,15 @@ public void deactivateUser(String accessID)
}
@Override
- public boolean isTenantAdmin(String user, String tenantName) {
+ public boolean isTenantAdmin(String user, String tenantId) {
Review comment:
Yes. Ideally `OMMultiTenantManager` and `OMTenantRequestHelper` should
be merged. While writing the Request code earlier it was easier to extract and
add my own helper methods rather than calling `OMMultiTenantManager` methods.
It is due for a refactoring. @prashantpogde and I can probably work together on
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
