smengcl commented on a change in pull request #3051:
URL: https://github.com/apache/ozone/pull/3051#discussion_r814140368
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantAssignUserAccessIdRequest.java
##########
@@ -308,20 +302,20 @@ public OMClientResponse validateAndUpdateCache(
principalInfo.addAccessId(accessId);
}
omMetadataManager.getPrincipalToAccessIdsTable().addCacheEntry(
- new CacheKey<>(principal),
+ new CacheKey<>(userPrincipal),
new CacheValue<>(Optional.of(principalInfo),
transactionLogIndex));
// Add to tenantGroupTable
- // TODO: DOUBLE CHECK GROUP NAME USAGE
+ // TODO: TenantGroupTable is unused for now.
Review comment:
Actually (mildly confusingly), `TenantGroupTable` is supposed to be used
to store all Ranger **roles** created for this tenant (`tenant-UserRole` and
`tenant-AdminRole`, at this point). -- Might be useful for the background sync
thread (when the logic is fixed).
The other one, `TenantRoleTable` is supposed to be used for storing the list
of tenant roles (not the Ranger roles) like admin/user/auditor? A concept
@prashantpogde introduced in the design phase but I don't see how it is
relevant at the moment. Probably could remove it or just use this one instead
of `TenantGroupTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
