smengcl commented on a change in pull request #3045:
URL: https://github.com/apache/ozone/pull/3045#discussion_r817672063
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -41,6 +41,7 @@ export OZONE_ACCEPTANCE_SUITE
cd "$DIST_DIR/compose" || exit 1
./test-all.sh 2>&1 | tee "${REPORT_DIR}/output.log"
RES=$?
-cp result/* "$REPORT_DIR/"
+cp -rv result/* "$REPORT_DIR/"
cp "$REPORT_DIR/log.html" "$REPORT_DIR/summary.html"
Review comment:
Not related to the PR, but I wonder: why do we copy `log.html` to
`summary.html`? Can we do a `mv`? Does some other script expect both `log.html`
and `summary.html`?
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -41,6 +41,7 @@ export OZONE_ACCEPTANCE_SUITE
cd "$DIST_DIR/compose" || exit 1
./test-all.sh 2>&1 | tee "${REPORT_DIR}/output.log"
RES=$?
-cp result/* "$REPORT_DIR/"
+cp -rv result/* "$REPORT_DIR/"
cp "$REPORT_DIR/log.html" "$REPORT_DIR/summary.html"
+find "$REPORT_DIR" -type f -empty -print0 | xargs -0 rm -v
Review comment:
Did we observe a lot of empty files in the output? (Examples would help
me understand)
IMO it's fine to keep those empty files that could make debugging the
scripts easier (e.g. HDDS-6327, to know if the output is empty or just not
copied over).
The empty file **names** could also hint devs new to the GH action result
what they should expect from the log bundles.
If there are specific empty files we want to remove we'd better remove them
explicitly, rather than removing all of them? Just my two cents.
Either way works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
