adoroszlai commented on a change in pull request #3045:
URL: https://github.com/apache/ozone/pull/3045#discussion_r817720158
##########
File path: hadoop-ozone/dev-support/checks/acceptance.sh
##########
@@ -41,6 +41,7 @@ export OZONE_ACCEPTANCE_SUITE
cd "$DIST_DIR/compose" || exit 1
./test-all.sh 2>&1 | tee "${REPORT_DIR}/output.log"
RES=$?
-cp result/* "$REPORT_DIR/"
+cp -rv result/* "$REPORT_DIR/"
cp "$REPORT_DIR/log.html" "$REPORT_DIR/summary.html"
+find "$REPORT_DIR" -type f -empty -print0 | xargs -0 rm -v
Review comment:
> IMO it's fine to keep those empty files that could make debugging the
scripts easier (e.g.
[HDDS-6327](https://issues.apache.org/jira/browse/HDDS-6327), to know if the
output is empty or just not copied over).
> The empty file **names** could also hint devs new to the GH action result
what they should expect from the log bundles.
`rm -v` logs each removed file:
```
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozones3-haproxy/dn-audit-1cd19fae6c57.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozones3-haproxy/dn-audit-95ac503d68be.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozones3-haproxy/dn-audit-ef4f89a73c5c.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/compatibility/dn-audit-b39600231102.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/compatibility/om-audit-5b26dee7469e.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-be6ca74b9449.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-fd71aac6c322.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/om-audit-09cb966c3428.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-a387313faada.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-062aff5d5db7.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/om-audit-86d09721dbb8.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-d0a6c4c4c964.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-2b903ea7ffe6.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-bfe17cc8ae0a.log'
removed
'/home/runner/work/ozone/ozone/hadoop-ozone/dev-support/checks/../../../target/acceptance/ozone-om-prepare/dn-audit-b53a2d4bd975.log'
...
```
https://github.com/apache/ozone/runs/5082868347#step:5:5192
I think that addresses both concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
