sodonnel commented on a change in pull request #3161:
URL: https://github.com/apache/ozone/pull/3161#discussion_r821127427
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ListPipelinesSubcommand.java
##########
@@ -39,23 +41,41 @@
versionProvider = HddsVersionProvider.class)
public class ListPipelinesSubcommand extends ScmSubcommand {
- @CommandLine.Option(names = {"-ffc", "--filterByFactor"},
- description = "Filter listed pipelines by Factor(ONE/one)",
+ @CommandLine.Option(names = {"-t", "--type"},
+ description = "Filter listed pipelines by replication type, RATIS or EC",
defaultValue = "")
- private String factor;
+ private String replicationType;
- @CommandLine.Option(names = {"-fst", "--filterByState"},
- description = "Filter listed pipelines by State(OPEN/CLOSE)",
Review comment:
I can add them back in, but in my opinion we shouldn't. The current
options don't fit with the convention of type / replication used everywhere
else and why do we even have "ffc" for "filter by factor"?
I am all for compatibility on important areas, but this is for a likely
rarely used command that is not critical for any operations on the cluster. The
extra options will make the help text look messy and we will end up carrying
around 4 ways to pass the factor forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
