adoroszlai commented on a change in pull request #3161:
URL: https://github.com/apache/ozone/pull/3161#discussion_r821372339
##########
File path:
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ListPipelinesSubcommand.java
##########
@@ -39,23 +41,41 @@
versionProvider = HddsVersionProvider.class)
public class ListPipelinesSubcommand extends ScmSubcommand {
- @CommandLine.Option(names = {"-ffc", "--filterByFactor"},
- description = "Filter listed pipelines by Factor(ONE/one)",
+ @CommandLine.Option(names = {"-t", "--type"},
+ description = "Filter listed pipelines by replication type, RATIS or EC",
defaultValue = "")
- private String factor;
+ private String replicationType;
- @CommandLine.Option(names = {"-fst", "--filterByState"},
- description = "Filter listed pipelines by State(OPEN/CLOSE)",
Review comment:
Thanks for restoring them. This command may look like rarely used, but
it is useful for automated testing (validating cluster state).
I agree that these old options are non-standard (and clumsy), and would like
to get rid of them eventually. But we should deprecate them first.
Co-existing old and new options allow non-breaking upgrade, giving time to
update test scripts. If we simply replace them, downstream users need to adapt
at the same time as bringing in these Ozone changes, which can be a chicken-egg
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
