smengcl commented on a change in pull request #3177:
URL: https://github.com/apache/ozone/pull/3177#discussion_r832724837
##########
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDBAccessIdInfo.java
##########
@@ -42,16 +47,23 @@
* Only effective if isAdmin is true.
*/
private final boolean isDelegatedAdmin;
+ /**
+ * Role names of the user (that this access ID is assigned to) in this
tenant.
+ * e.g. OzoneConsts.TENANT_ROLE_USER, OzoneConsts.TENANT_ROLE_ADMIN,
+ * or other custom role names.
+ */
+ private final Set<String> roleIds;
Review comment:
~~I use "Id" suffix here just to be consistent with others:~~
```
tenantId = tenant name
policyId = policy name
roleId = role name
```
~~Yeah it is a bit misleading as none of those "Id"s means "number".~~
~~Maybe change all of them (back) to a "Name" suffix?~~
It turns out some roleId actually means a number (in other cases). I have
changed it to `roleNames` in `OmDBAccessIdInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
