smengcl commented on a change in pull request #3177:
URL: https://github.com/apache/ozone/pull/3177#discussion_r832732467



##########
File path: 
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmDBAccessIdInfo.java
##########
@@ -42,16 +47,23 @@
    * Only effective if isAdmin is true.
    */
   private final boolean isDelegatedAdmin;
+  /**
+   * Role names of the user (that this access ID is assigned to) in this 
tenant.
+   * e.g. OzoneConsts.TENANT_ROLE_USER, OzoneConsts.TENANT_ROLE_ADMIN,
+   *      or other custom role names.
+   */
+  private final Set<String> roleIds;

Review comment:
       For PolicyID, we do use the number, but stored as String: 
   
   
https://github.com/apache/ozone/blob/8ecff6fd1a5842e8c81c125fd1d5aa729b7c7a47/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/multitenant/RangerAccessPolicy.java#L72
   
   If we change it to `long` we should change the type in `OmDBTenantState` as 
well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to