guihecheng commented on a change in pull request #3176:
URL: https://github.com/apache/ozone/pull/3176#discussion_r833042668
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RDBTable.java
##########
@@ -57,6 +57,7 @@
private final ColumnFamilyHandle handle;
private final WriteOptions writeOptions;
private final RDBMetrics rdbMetrics;
+ private int prefixLength;
Review comment:
OK...I found it not so easy to pass then extract prefix using the
`MetadataKeyFilters.MetadataKeyFilter`, because the KeyFilter interface doesn't
offer convenient interface for that and hard to refactor. And also we haven't
introduced the fixed-length prefix stuff for schemaV3 keys and we can't assume
the char encoding in general purpose classes like
`MetadataKeyFilters.MetadataKeyFilter` or `RDBTable`.
I'm trying to add a new parameter `prefix` to the `getRangeKVs` &
`getSequentialRangeKVs` interfaces.
I feel that it is painful to do so, but I would like to have abstracted
interfaces for all schemas instead of `if-else` checks in each call place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
