guihecheng commented on pull request #3176: URL: https://github.com/apache/ozone/pull/3176#issuecomment-1076358571
Hi @nandakumar131 , I'm sorry that I have to do a force push since I did a rebase on HDDS-3630, because the new changes will conflict with the merged HDDS-6404. Here I did remove the `setFixedPrefixLength` at table level, but to pass the necessary prefix to the rocksdb, I have to add a new parameter to the interfaces `getRangeKVs ` and `getSequentialRangeKVs `. Originally I tends to extract the prefix in the `startKey` with the `prefixLength`, but it is not good. And I tried to extract the prefix from the KeyFilters, but the prefix should go through a proper the codec classes in `TypedTable`, but the KeyFilter has its own way to manage positive and negative prefixes, which is hard to refactor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
