kerneltime commented on a change in pull request #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r840868115
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/EventQueue.java
##########
@@ -58,10 +61,29 @@
private boolean isRunning = true;
- private static final Gson TRACING_SERIALIZER = new GsonBuilder().create();
+ private static final Gson TRACING_SERIALIZER = new GsonBuilder()
+ .setExclusionStrategies(new DatanodeDetailsGsonExclusionStrategy())
+ .create();
private boolean isSilent = false;
+ // The field parent in DatanodeDetails class has the circular reference
+ // which will result in Gson infinite recursive parsing. We need to exclude
+ // this field when generating json string for DatanodeDetails object
+ static class DatanodeDetailsGsonExclusionStrategy
Review comment:
This change can be merged as a quick PR and not wait on this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
