kerneltime commented on a change in pull request #3186: URL: https://github.com/apache/ozone/pull/3186#discussion_r840884541
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeIpOrHostnameUpdateHandler.java ########## @@ -0,0 +1,71 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.hdds.scm.node; + +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.scm.ha.SCMService; +import org.apache.hadoop.hdds.scm.ha.SCMServiceManager; +import org.apache.hadoop.hdds.scm.node.states.NodeNotFoundException; +import org.apache.hadoop.hdds.scm.pipeline.PipelineManager; +import org.apache.hadoop.hdds.server.events.EventHandler; +import org.apache.hadoop.hdds.server.events.EventPublisher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Handles datanode ip or hostname change event. + */ +public class NodeIpOrHostnameUpdateHandler + implements EventHandler<DatanodeDetails> { + private static final Logger LOG = + LoggerFactory.getLogger(NodeIpOrHostnameUpdateHandler.class); + + private final PipelineManager pipelineManager; + private final NodeDecommissionManager decommissionManager; + private final SCMServiceManager serviceManager; + + public NodeIpOrHostnameUpdateHandler(PipelineManager pipelineManager, + NodeDecommissionManager decommissionManager, + SCMServiceManager serviceManager) { + this.pipelineManager = pipelineManager; + this.decommissionManager = decommissionManager; + this.serviceManager = serviceManager; + } + + @Override + public void onMessage(DatanodeDetails datanodeDetails, + EventPublisher publisher) { + try { + pipelineManager.closeStalePipelines(datanodeDetails); + serviceManager.notifyEventTriggered(SCMService.Event + .NODE_IP_OR_HOSTNAME_UPDATE_HANDLER_TRIGGERED); + + if (datanodeDetails.getPersistedOpState() + != HddsProtos.NodeOperationalState.IN_SERVICE) { + decommissionManager.continueAdminForNode(datanodeDetails); Review comment: It might be better to depend on the guarantees of `continueAdminForNode` (need to update javadoc for `continueAdminForNode`) and always call that method here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
