ArafatKhan2198 commented on code in PR #3302:
URL: https://github.com/apache/ozone/pull/3302#discussion_r852177684
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/ObjectEndpoint.java:
##########
@@ -230,6 +230,14 @@ public Response put(
}
LOG.error("Exception occurred in PutObject", ex);
throw ex;
+ } catch (OS3Exception ex) {
+ if (copyHeader != null) {
+ getMetrics().incCopyObjectFailure();
+ } else {
+ LOG.error("Exception occurred in PutObject", ex.getMessage());
Review Comment:
Thanks for pointing that out, we should be logging the error outside the
if-else block so as to notify the user that the create key method has failed
because an S3 exception was thrown !!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
