symious commented on PR #3350: URL: https://github.com/apache/ozone/pull/3350#issuecomment-1119141075
Indeed, the name can be changed, but this change is evitable. In fact, I don't have any questions on the topology content of "network-topology-default.xml", I have took some time checking the code to realize that the node schema file is of different means with the action topology in code. But the confusion still exists as follows: 1. topology in network-topology-default.xml is "/datacenter/rack/node", but the actual topology in code is "/rack/node", they are different. 2. topology in network-topology-default.xml is "/datacenter/rack/node", but the topology in network-topology-default.yaml is "/root/datacenter/rack/node", they are different. 3. "datacenter" is already in topology in network-topology-default.xml, if I need to add a new level named datacenter, I need to change the name of the first "datacenter", will it cause any issues? And I think these confusions should come to most of the users trying to work with the topology, although these are not hard to find the answers, they still need to spend some time to solve these confusions before they can work on. IMHO, one of the benifits of open-source is reduce repeat solving problems, if one problem or confusion solved, others can take advantages of it, time can be saved to work on other features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
