errose28 commented on code in PR #3226:
URL: https://github.com/apache/ozone/pull/3226#discussion_r867174842
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1027,6 +1027,7 @@ message OpenKeyBucket {
message OpenKey {
required string name = 1;
required uint64 clientID = 2;
+ optional uint64 parentID = 3;
Review Comment:
I believe this will work. The bucket layout should be set based on whether
the key was retrieved from the open key table or open file table, since the
bucket itself may no longer exist. The field will be used by followers to know
which table they need to move the key from.
It is interesting that FSO has its own table for open keys, but looks to
share the same delete table as OBS and LEGACY keys. I would think there would
either be different tables for both or they would both use the same table.
Either way, by having this bucket layout field we could handle a delete table
unique to FSO in the future. cc @rakeshadr to inquire why the tables are used
in this way out of curiosity, although it does not really affect this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
