errose28 commented on code in PR #3226:
URL: https://github.com/apache/ozone/pull/3226#discussion_r867180563
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1027,11 +1027,12 @@ message OpenKeyBucket {
required string volumeName = 1;
required string bucketName = 2;
repeated OpenKey keys = 3;
+ optional BucketLayoutProto bucketLayout = 4; // TODO: change to required
}
message OpenKey {
required string name = 1;
- required uint64 clientID = 2;
+ optional uint64 clientID = 2; // TODO: to be removed
Review Comment:
protolock probably won't let you get rid of this field (even though this
proto is not used yet) which is unfortunate. Not a huge deal since this is only
used between OMs. Maybe adding `[deprecated=true]` is the best we can do.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1027,11 +1027,12 @@ message OpenKeyBucket {
required string volumeName = 1;
required string bucketName = 2;
repeated OpenKey keys = 3;
+ optional BucketLayoutProto bucketLayout = 4; // TODO: change to required
Review Comment:
I don't think we want to be adding new required fields. Probably best to
throw an error on the server side if this is not present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
