guihecheng commented on code in PR #3392:
URL: https://github.com/apache/ozone/pull/3392#discussion_r868901756
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -114,8 +123,12 @@ public void createWorkingDir(String workingDirName,
MutableVolumeSet dbVolumeSet) throws IOException {
super.createWorkingDir(workingDirName, dbVolumeSet);
- if (SchemaV3.isFinalizedAndEnabled(getConf())) {
- createDbStore(dbVolumeSet);
+ // Create DB store for a newly added volume
+ if (!isTest) {
+ if (VersionedDatanodeFeatures.isFinalized(
+ HDDSLayoutFeature.ERASURE_CODED_STORAGE_SUPPORT)) {
Review Comment:
Hmmm, got it, but this check still seems odd, maybe we could give some
comments over it to make it more understandable?
Or extract it to a function, give it a sensible name and some comments?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -114,8 +123,12 @@ public void createWorkingDir(String workingDirName,
MutableVolumeSet dbVolumeSet) throws IOException {
super.createWorkingDir(workingDirName, dbVolumeSet);
- if (SchemaV3.isFinalizedAndEnabled(getConf())) {
- createDbStore(dbVolumeSet);
+ // Create DB store for a newly added volume
+ if (!isTest) {
+ if (VersionedDatanodeFeatures.isFinalized(
+ HDDSLayoutFeature.ERASURE_CODED_STORAGE_SUPPORT)) {
Review Comment:
Hmmm, got it, but this check still looks odd, maybe we could give some
comments over it to make it more understandable?
Or extract it to a function, give it a sensible name and some comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
