ChenSammi commented on code in PR #3392: URL: https://github.com/apache/ozone/pull/3392#discussion_r868927484
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/upgrade/DatanodeSchemaV3FinalizeAction.java: ########## @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.container.upgrade; + +import org.apache.hadoop.hdds.upgrade.HDDSUpgradeAction; +import org.apache.hadoop.ozone.container.common.statemachine.DatanodeConfiguration; +import org.apache.hadoop.ozone.container.common.statemachine.DatanodeStateMachine; +import org.apache.hadoop.ozone.container.common.utils.HddsVolumeUtil; +import org.apache.hadoop.ozone.container.common.volume.HddsVolume; +import org.apache.hadoop.ozone.container.common.volume.MutableVolumeSet; +import org.apache.hadoop.ozone.container.common.volume.StorageVolume; +import org.apache.hadoop.ozone.upgrade.UpgradeActionHdds; +import org.apache.ratis.util.Preconditions; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import static org.apache.hadoop.hdds.upgrade.HDDSLayoutFeature.DATANODE_SCHEMA_V3; +import static org.apache.hadoop.ozone.upgrade.LayoutFeature.UpgradeActionType.ON_FINALIZE; +import static org.apache.hadoop.ozone.upgrade.UpgradeActionHdds.Component.DATANODE; + +/** + * Upgrade Action for DataNode for SCHEMA V3. + */ +@UpgradeActionHdds(feature = DATANODE_SCHEMA_V3, component = DATANODE, + type = ON_FINALIZE) +public class DatanodeSchemaV3FinalizeAction + implements HDDSUpgradeAction<DatanodeStateMachine> { + + public static final Logger LOG = + LoggerFactory.getLogger(DatanodeSchemaV3FinalizeAction.class); + + @Override + public void execute(DatanodeStateMachine dsm) throws Exception { + LOG.info("Upgrading Datanode volume layout for Schema V3 support."); + + // Load RocksDB for each HddsVolume, build the relationship between + // HddsVolume and DbVolume if DbVolume is configured. + MutableVolumeSet dataVolumeSet = dsm.getContainer().getVolumeSet(); + MutableVolumeSet dbVolumeSet = dsm.getContainer().getDbVolumeSet(); + Preconditions.assertNotNull(dataVolumeSet, "Data Volume should be null"); + Preconditions.assertNotNull(dataVolumeSet, "Data Volume should be null"); + dataVolumeSet.writeLock(); + try { + for (StorageVolume hddsVolume : dataVolumeSet.getVolumesList()) { + HddsVolume dataVolume = (HddsVolume) hddsVolume; + if (dataVolume.getDbParentDir() != null) { + // The RocksDB for this hddsVolume is already created(newly added + // volume case). + continue; + } + dataVolume.createDbStore(dbVolumeSet); + } + } finally { + dataVolumeSet.writeUnlock(); + } + DatanodeConfiguration dcf = + dsm.getConf().getObject(DatanodeConfiguration.class); + if (!dcf.getContainerSchemaV3Enabled()) { + LOG.info("SchemaV3 is disabled. Don't load RocksDB in upgrade."); Review Comment: OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
