kerneltime commented on code in PR #3429:
URL: https://github.com/apache/ozone/pull/3429#discussion_r877657651
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx:
##########
@@ -272,6 +274,15 @@ const COLUMNS = [
isSearchable: true,
sorter: (a: IDatanode, b: IDatanode) =>
a.buildDate.localeCompare(b.buildDate),
defaultSortOrder: 'ascend' as const
+ },
+ {
+ title: 'NetworkLocation',
Review Comment:
Since there are column titles it would make sense to add space instead of
using CamelCase-ish names
NetworkLocation -> Network Location or Network location.
This would be needed for all the columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
