symious commented on code in PR #3429:
URL: https://github.com/apache/ozone/pull/3429#discussion_r882462894
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/NodeEndpoint.java:
##########
@@ -148,6 +148,7 @@ public Response getDatanodes() {
.withBuildDate(nodeManager.getBuildDate(datanode))
.withLayoutVersion(
dnInfo.getLastKnownLayoutVersion().getMetadataLayoutVersion())
+ .withNetworkLocation(datanode.getNetworkLocation())
.build());
Review Comment:
@neils-dev Thanks for the review.
I'm not sure if `nodeManager.getClusterNetworkTopologyMap()` is the
interface for the requirement. For the networkLocation of each datanode, I
think NodeManager can already return the datanodes which can be treated as
`Node` to get the networkLocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
