sokui commented on code in PR #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r877796519
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java:
##########
@@ -369,6 +384,12 @@ public static Long getMinReplicatedIndex(
.min(Long::compareTo).orElse(null);
}
+ private static boolean datanodeUseHostName() {
+ return CONF.getBoolean(
+ DFSConfigKeys.DFS_DATANODE_USE_DN_HOSTNAME,
+ DFSConfigKeys.DFS_DATANODE_USE_DN_HOSTNAME_DEFAULT);
Review Comment:
I found that these two properties are used in somewhere else in the code
(not my code), that's why I reuse them here. Do you want me to also change
property of that place, or you think it is ok we have both
hdds.datanode.use.datanode.hostname and dfs.datanode.use.datanode.hostname?
@adoroszlai
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
