sokui commented on code in PR #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r878411253
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NewNodeHandler.java:
##########
@@ -56,6 +56,7 @@ public NewNodeHandler(PipelineManager pipelineManager,
public void onMessage(DatanodeDetails datanodeDetails,
EventPublisher publisher) {
try {
+ pipelineManager.closeStalePipelines(datanodeDetails);
Review Comment:
Yeah. This is necessary. I believe in my testing, if a datanode is dead for
a long time, SCM will remove it from the registration list. When the node comes
up with a different IP, it first registers with SCM, and SCM treat it as a new
node. But the old pipeline with the old IPs may still be there.
Another way to achieve this is to delete the pipelines if SCM is going to
remove the dead nodes. But I am not that familiar with this part of the code. I
may need to have a further look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
