Xushaohong commented on code in PR #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r878173838
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NewNodeHandler.java:
##########
@@ -56,6 +56,7 @@ public NewNodeHandler(PipelineManager pipelineManager,
public void onMessage(DatanodeDetails datanodeDetails,
EventPublisher publisher) {
try {
+ pipelineManager.closeStalePipelines(datanodeDetails);
Review Comment:
is closeStalePipelines necessary here? Since when SCM processes the
register command, it should be able to distinguish the new node / updated node,
and here should be only responsible for the new node case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
