Xushaohong commented on code in PR #3186:
URL: https://github.com/apache/ozone/pull/3186#discussion_r878700113
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NewNodeHandler.java:
##########
@@ -56,6 +56,7 @@ public NewNodeHandler(PipelineManager pipelineManager,
public void onMessage(DatanodeDetails datanodeDetails,
EventPublisher publisher) {
try {
+ pipelineManager.closeStalePipelines(datanodeDetails);
Review Comment:
According to your implementation, when the node comes up with a different
IP, it will register first with SCM, SCM node manager will get it as long as
its UUID is not changed through ```isNodeRegistered```. Since it triggers the
event of address updated event and in which it will **close state pipelines**
and update node info, also creating new pipelines.
For the ``` New node``` case, I think we do not need this close action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
