JacksonYao287 commented on PR #3445: URL: https://github.com/apache/ozone/pull/3445#issuecomment-1135343178
i have force-updated this patch. in the new patch: 1 add a common background scm service final class. after investigating , i think no need to add an abstract class, a final class is enough. we can create different background scm service just by changing the parameters in the builders. the task schedule logic can be shared naturally. for backgroundPipelineScrubber, we can just change the periodical task to `pipelineManager.scrubPipelines()`. for ReplicationManager, we can add a internal background scm service and set the periodical task to `processALL()` 2 I also am not sure if we should be adding config in the way i have done here, or using the "Type Safe" approach. so i keep the approach like this for now, and can be changed later after we reach an agreement on this top. seems not complex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
