sodonnel commented on code in PR #3445:
URL: https://github.com/apache/ozone/pull/3445#discussion_r880355277
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -625,6 +626,36 @@ private void initializeSystemManagers(OzoneConfiguration
conf,
}
containerReplicaPendingOps = new ContainerReplicaPendingOps(conf, clock);
+
+ long intervalInMillis = conf.getTimeDuration(
+ ScmConfigKeys
+ .OZONE_SCM_EXPIRED_CONTAINER_REPLICA_OP_SCRUB_INTERVAL,
+ ScmConfigKeys
+ .OZONE_SCM_EXPIRED_CONTAINER_REPLICA_OP_SCRUB_INTERVAL_DEFAULT,
+ TimeUnit.MILLISECONDS);
+
+ long expiryMilliSeconds = conf.getTimeDuration(
Review Comment:
Just thinking that we may have different background threads if we reuse this
class - maybe these variables should have a better name, eg
containerReplicaOpExipryMs, containerReplicaOpScrubberIntervalMs.
waitTimeInMillis can be re-used for several services,
`backgroundServiceSafemodeWaitMs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
