smengcl commented on code in PR #3018:
URL: https://github.com/apache/ozone/pull/3018#discussion_r882965082
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.1.0-1.2.0/callback.sh:
##########
@@ -64,8 +64,7 @@ with_old_version_downgraded() {
with_new_version_finalized() {
_check_hdds_mlvs 2
- # OM currently only has one layout version.
- _check_om_mlvs 0
Review Comment:
Hmm. When checking the actual PR merged into the multi-tenancy feature
branch I don't even see this line of diff in `pre_finalized` (but only the
correct change in `finalized`):
https://github.com/apache/ozone/commit/83a8c5f14b28b03d7f852bbde1dd34610b4c67a0#diff-e3e12e2c91ceb55ac732d790d28f0bab60bed840ca61b5315c1d5c5d874ed2baL65-L68
The incorrect diff you pointed out doesn't seem to exist in the actual
squashed commit. So weird. Is it some kind of GitHub diff bug? (I might have
done the incorrect change at some point but reverted it?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
