smengcl commented on code in PR #3018:
URL: https://github.com/apache/ozone/pull/3018#discussion_r882973158
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.1.0-1.2.0/callback.sh:
##########
@@ -64,8 +64,7 @@ with_old_version_downgraded() {
with_new_version_finalized() {
_check_hdds_mlvs 2
- # OM currently only has one layout version.
- _check_om_mlvs 0
Review Comment:
I was going to say when I was merging master to the feature branch just 3
days ago, I had to bump the `_check_om_mlvs` further to 3 to pass acceptance
(misc):
https://github.com/apache/ozone/blame/HDDS-4944/hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh#L74
But then I realized this is the one from 1.1.0 to 1.2.0.
Yup so in this case it should still be zero (in 1.2.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
