lokeshj1703 commented on code in PR #3455:
URL: https://github.com/apache/ozone/pull/3455#discussion_r891039377
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/AbstractFindTargetGreedy.java:
##########
@@ -162,9 +165,16 @@ private boolean containerMoveSatisfiesPlacementPolicy(
.filter(datanodeDetails -> !datanodeDetails.equals(source))
.collect(Collectors.toList());
replicaList.add(target);
- ContainerPlacementStatus placementStatus =
- placementPolicy.validateContainerPlacement(replicaList,
- containerInfo.getReplicationConfig().getRequiredNodes());
+ ContainerPlacementStatus placementStatus;
+ switch (containerInfo.getReplicationType()) {
+ case EC:
+ placementStatus = ecPlacementPolicy.validateContainerPlacement(
+ replicaList,
containerInfo.getReplicationConfig().getRequiredNodes());
+ break;
+ default:
+ placementStatus = placementPolicy.validateContainerPlacement(replicaList,
+ containerInfo.getReplicationConfig().getRequiredNodes());
+ }
Review Comment:
Better to move it to a separate function.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/AbstractFindTargetGreedy.java:
##########
@@ -55,10 +56,12 @@ public abstract class AbstractFindTargetGreedy implements
FindTargetStrategy {
protected AbstractFindTargetGreedy(
ContainerManager containerManager,
PlacementPolicy placementPolicy,
+ PlacementPolicy ecPlacementPolicy,
NodeManager nodeManager) {
sizeEnteringNode = new HashMap<>();
this.containerManager = containerManager;
this.placementPolicy = placementPolicy;
+ this.ecPlacementPolicy = ecPlacementPolicy;
Review Comment:
I think it might be better to not have different placement policy fields? We
need a better way to fetch these placement policies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
