lokeshj1703 commented on code in PR #3455:
URL: https://github.com/apache/ozone/pull/3455#discussion_r929586692
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/AbstractFindTargetGreedy.java:
##########
@@ -45,7 +44,7 @@
public abstract class AbstractFindTargetGreedy implements FindTargetStrategy {
private Logger logger;
private ContainerManager containerManager;
- private PlacementPolicy placementPolicy;
+ private PlacementPolicyValidateProxy placementPolicyValidateProxy;
Review Comment:
Can we create an instance of it inside SCM? I think it can be used by
balancer and other components as well.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -607,8 +607,7 @@ private void initializeSystemManagers(OzoneConfiguration
conf,
long term = SCMHAUtils.isSCMHAEnabled(conf) ? 0 :
SCMContext.INVALID_TERM;
// non-leader of term 0, in safe mode, preCheck not completed.
scmContext = new SCMContext.Builder()
- .setLeader(false)
- .setTerm(term)
+ .setLeader(false).setTerm(term)
Review Comment:
unintended change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
