sodonnel commented on code in PR #3550:
URL: https://github.com/apache/ozone/pull/3550#discussion_r907263321
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ec/reconstruction/ECReconstructionSupervisor.java:
##########
@@ -38,6 +39,11 @@ public class ECReconstructionSupervisor implements Closeable
{
private final StateContext context;
private final ExecutorService executor;
private final ECReconstructionCoordinator reconstructionCoordinator;
+ /**
+ * how many coordinator tasks currently being running.
+ */
+ private final ConcurrentHashMap.KeySetView<Object, Boolean>
Review Comment:
These seems to be copied from the ReplicationSupervisor - do we have a plan
to use this for more than just counting tasks? Could we use an atomicLong as a
simple counter instead?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ec/reconstruction/ECReconstructionSupervisor.java:
##########
@@ -38,6 +39,11 @@ public class ECReconstructionSupervisor implements Closeable
{
private final StateContext context;
private final ExecutorService executor;
private final ECReconstructionCoordinator reconstructionCoordinator;
+ /**
+ * how many coordinator tasks currently being running.
+ */
+ private final ConcurrentHashMap.KeySetView<Object, Boolean>
Review Comment:
This seems to be copied from the ReplicationSupervisor - do we have a plan
to use this for more than just counting tasks? Could we use an atomicLong as a
simple counter instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
