umamaheswararao commented on code in PR #3550:
URL: https://github.com/apache/ozone/pull/3550#discussion_r907473592
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ec/reconstruction/ECReconstructionSupervisor.java:
##########
@@ -38,6 +39,11 @@ public class ECReconstructionSupervisor implements Closeable
{
private final StateContext context;
private final ExecutorService executor;
private final ECReconstructionCoordinator reconstructionCoordinator;
+ /**
+ * how many coordinator tasks currently being running.
+ */
+ private final ConcurrentHashMap.KeySetView<Object, Boolean>
Review Comment:
Yes, Just used this from ReplicationSupervisor. I thought is atomicLong, but
looks like we are trying to avoid duplicate task for same command by any chance.
While adding task:
if (inProgressReconstrucionCoordinatorCounter
.add(taskInfo.getContainerID())) {
I thought this may be useful check for safety and may avoid any accidental
corruption due to fight two containers. Ideally that should be protected as we
would create containers, the other one should fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
