sodonnel commented on code in PR #3542:
URL: https://github.com/apache/ozone/pull/3542#discussion_r907430801
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECContainerHealthCheck.java:
##########
@@ -89,19 +96,33 @@ public ContainerHealthResult checkHealth(ContainerInfo
container,
return new ContainerHealthResult.HealthyResult(container);
}
- private ECContainerReplicaCount getReplicaCountWithPending(
+ private static ECContainerReplicaCount getReplicaCountWithPending(
Review Comment:
I guess whole method is not needed now, after the change in HDDS-6699 goes
in - we are just passing the List<ContainerReplicaOp> through all the methods
directly.
As an aside, we would not have needed to create a new instance of
`ContainerReplicaPendingOps` here to form the list - we could have just created
a list of ops directly. However I don't think we need any of this after we
commit the above Jira, so its not important now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
