sodonnel commented on code in PR #3542:
URL: https://github.com/apache/ozone/pull/3542#discussion_r907480075
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/states/TestECContainerReplicaCount.java:
##########
@@ -88,10 +95,14 @@ public void testContainerMissingReplicaDueToPendingDelete()
{
registerNodes(Pair.of(IN_SERVICE, 1), Pair.of(IN_SERVICE, 2),
Pair.of(IN_SERVICE, 3), Pair.of(IN_SERVICE, 4),
Pair.of(IN_SERVICE, 5));
- List<Integer> delete = new ArrayList<>();
- delete.add(1);
- ECContainerReplicaCount rcnt = new ECContainerReplicaCount(container,
- replica, new ArrayList<>(), delete, 1);
+ ContainerReplicaPendingOps pendingOps =
Review Comment:
We don't need an instance of ContainerReplicaPendingOps for these tests.
Just:
```
List<ContainerReplicaOP> pending = new ArrayList<>();
pending.add(ContainerReplicaOp.create(...));
```
Note, I think the static `ContainerReplicaOp.create` method is only added in
HDDS-6699 - ie not yet committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
