adoroszlai commented on code in PR #3553:
URL: https://github.com/apache/ozone/pull/3553#discussion_r907736460
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java:
##########
@@ -98,6 +101,7 @@ protected OzoneBucket getBucket(OzoneVolume volume, String
bucketName)
@PostConstruct
public void initialization() {
LOG.debug("S3 access id: {}", s3Auth.getAccessID());
+ ozoneConfiguration.setIfUnset("ozone.om.group.rights", "NONE");
Review Comment:
> The config is defined in
https://github.com/apache/ozone/blob/master/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneAclConfig.java#L42-L48
Thanks, I forgot about that.
> the actual string for configuration cannot be searched as plain text as
the configuration splits it into 2 parts.
That's true.
> Also, the defaults are set deep inside RpcClient
Not really, the default is defined in `OzoneAclConfig`, not in `RpcClient`.
> vs being set close to the business logic in s3g. Ideally the group
security setting should have been part of the Bucket Endpoint processing itself.
I don't think this setting is specific to S3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
