kerneltime commented on code in PR #3553:
URL: https://github.com/apache/ozone/pull/3553#discussion_r907965379
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java:
##########
@@ -63,6 +64,8 @@ public abstract class EndpointBase implements Auditor {
private S3Auth s3Auth;
@Context
private ContainerRequestContext context;
+ @Inject
+ private OzoneConfiguration ozoneConfiguration;
Review Comment:
I would like it to be as close to request processing and to make the actual
ACL setup as obvious as possible. This allow for more eyeballs looking at the
code and its details and improves information density in the command processing
code path vs. defaults being set transparently many layers down (as it was).
I agree that it is better to define this in the Configuration Holder as we
never want the group policy to be set in any S3 context unless explicitly set.
Updated the PR with the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
