JacksonYao287 commented on code in PR #3514:
URL: https://github.com/apache/ozone/pull/3514#discussion_r915787932
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java:
##########
@@ -229,10 +229,17 @@ protected List<ChunkInfo> getChunkInfos() throws
IOException {
blockID.getContainerID());
}
- DatanodeBlockID datanodeBlockID = blockID
- .getDatanodeBlockIDProtobuf();
+ DatanodeBlockID.Builder blkIDBuilder =
+ DatanodeBlockID.newBuilder().setContainerID(blockID.getContainerID())
+ .setLocalID(blockID.getLocalID())
+ .setBlockCommitSequenceId(blockID.getBlockCommitSequenceId());
Review Comment:
blockCommitSequenceID is used for handling quosi_closed ratis container
which has a non-determined state. so i don`t think it has any use for EC
container. maybe we can remove it for EC case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
