umamaheswararao commented on code in PR #3514:
URL: https://github.com/apache/ozone/pull/3514#discussion_r916014835
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockInputStream.java:
##########
@@ -229,10 +229,17 @@ protected List<ChunkInfo> getChunkInfos() throws
IOException {
blockID.getContainerID());
}
- DatanodeBlockID datanodeBlockID = blockID
- .getDatanodeBlockIDProtobuf();
+ DatanodeBlockID.Builder blkIDBuilder =
+ DatanodeBlockID.newBuilder().setContainerID(blockID.getContainerID())
+ .setLocalID(blockID.getLocalID())
+ .setBlockCommitSequenceId(blockID.getBlockCommitSequenceId());
Review Comment:
We have not really thought much about BCSID. Currently we are not using it,
but we need to think whether we have benefit or take advantage of any other
scenarios which we have not covered yet. So, I think it may be too early to
discard. Eventually we can ignore that later times if we never find any use of
it. I suggest to get set as it is available now. Also we surely don't want to
ignore in BlockInputStream as that is non EC code flow too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
