kerneltime commented on code in PR #3588:
URL: https://github.com/apache/ozone/pull/3588#discussion_r919437292
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/multitenant/AuthorizerLockImpl.java:
##########
@@ -132,11 +132,12 @@ public long tryWriteLockThrowOnTimeout() throws
IOException {
@Override
public void tryWriteLockInOMRequest() throws IOException {
+ long stamp = tryWriteLockThrowOnTimeout();
+
// Sanity check. Must not have held a write lock in a tenant OMRequest.
Preconditions.checkArgument(omRequestWriteLockStamp == 0L);
Review Comment:
In the case of a bug causing the `Precondition` to fail, we are still
holding with the lock when an `IllegalArgumentException` is thrown due to the
check having failed. It is a minor nit and unlikely to occur but from a
completeness stand point, we should release the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
