kerneltime commented on code in PR #3588:
URL: https://github.com/apache/ozone/pull/3588#discussion_r919556183
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/multitenant/AuthorizerLockImpl.java:
##########
@@ -132,11 +132,12 @@ public long tryWriteLockThrowOnTimeout() throws
IOException {
@Override
public void tryWriteLockInOMRequest() throws IOException {
+ long stamp = tryWriteLockThrowOnTimeout();
+
// Sanity check. Must not have held a write lock in a tenant OMRequest.
Preconditions.checkArgument(omRequestWriteLockStamp == 0L);
Review Comment:
@smengcl this is a bug around tenant administration, not sure if crashing OM
would be the right way. That said, I agree that if precondition were to fail,
it would imply a serious coding issue here... At a minimum we need to clean up
the precondition check in `validateAndUpdateCache` and insure that the lock is
unlocked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
