kerneltime commented on code in PR #3594:
URL: https://github.com/apache/ozone/pull/3594#discussion_r920351026


##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -833,7 +833,7 @@ message ListBucketsResponse {
 }
 
 message KeyArgs {
-    required string volumeName = 1;
+    optional string volumeName = 1;

Review Comment:
   I don't think we should make a change to the underlying proto message of 
this nature.
   We will need to discuss the upgrade implications for this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to