duongnguyen0 commented on PR #3594: URL: https://github.com/apache/ozone/pull/3594#issuecomment-1187697338
> Thanks @duongnguyen0 for refining the patch. Can ObjectEndpoint use ClientProtocol/RpcClient directly, instead of having to pollute OzoneVolume with key-related operations? Yes, it can be done that way. I decided to follow the precedence to easily stub the `OzoneVolume` for testing. But maybe it's not worth it to add some unhelpful code to `OzoneVolume`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
