nandakumar131 commented on code in PR #3582: URL: https://github.com/apache/ozone/pull/3582#discussion_r920732754
########## hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/codec/OmDBSnapshotInfoCodec.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.om.codec; + +import org.apache.hadoop.hdds.utils.db.Codec; +import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos.SnapshotInfoEntry; +import org.apache.hadoop.ozone.om.helpers.SnapshotInfo; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; + +import static com.google.common.base.Preconditions.checkNotNull; + +/** + * Codec to encode SnapshotInfo as byte array. + */ +public class OmDBSnapshotInfoCodec implements Codec<SnapshotInfo> { + private static final Logger LOG = + LoggerFactory.getLogger(OmDBSnapshotInfoCodec.class); + + @Override + public byte[] toPersistedFormat(SnapshotInfo object) throws IOException { + checkNotNull(object, "Null object can't be converted to byte array."); + return object.getProtobuf().toByteArray(); + } + + @Override + public SnapshotInfo fromPersistedFormat(byte[] rawData) + throws IOException { + checkNotNull(rawData, "Null byte array can't be converted to " + + "real object."); + return SnapshotInfo.getFromProtobuf( + SnapshotInfoEntry.parseFrom(rawData)); + } + + @Override + public SnapshotInfo copyObject(SnapshotInfo object) { + // Note: Not really a "copy". from OMDBSnapshotInfoCodec + return object; Review Comment: As George pointed out, we can do a real copy here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
