neils-dev commented on code in PR #3582:
URL: https://github.com/apache/ozone/pull/3582#discussion_r922906141
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -711,6 +711,31 @@ message PrefixInfo {
optional uint64 updateID = 5;
}
+/**
+ * SnapshotStatus - snapshot states.
+ * Snapshot in one of : active, deleted, or reclaimed state
+ */
+enum SnapshotStatusProto {
+ SNAPSHOT_ACTIVE = 1;
+ SNAPSHOT_DELETED = 2;
+ SNAPSHOT_RECLAIMED = 3;
+}
+
+/**
+ * SnapshotInfo table entry for Bucket/Volume snapshot metadata
+ */
+message SnapshotInfoEntry {
Review Comment:
By using `SnapshotInfo` both for the proto and the class, it makes some
declarations ambiguous without fully qualifying the objects used. I too wanted
to use `SnapshotInfo` for the proto definition at first. I avoided the
ambiguity by using a unique identifier (`SnapshotInfoEntry`) for the proto
snapshotinfo definition.
As you suggested, I renamed the proto definition to `SnapshotInfo` and fully
qualified the use of the proto where needed. In latest commit. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
