umamaheswararao commented on code in PR #3599: URL: https://github.com/apache/ozone/pull/3599#discussion_r922457958
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReplicateContainerCommand.java: ########## @@ -41,6 +41,7 @@ private final long containerID; private final List<DatanodeDetails> sourceDatanodes; + private int replicaIndex = 0; Review Comment: We discussed offline about alternative approach to get the replicaIndex. I am updating here for the discussion context. We discussed that this may be ok and simpler, even though we are not using this at the DN side currently. We could potentially use this for validation purposes if needed. The alternative method is that we could add a methods at ContainerManager to get the replicaIndex and we can use that method to get replicaIndex for a given node. After discussion we felt this is ok to just add to command rather than going back to container manager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
