adoroszlai commented on code in PR #3599:
URL: https://github.com/apache/ozone/pull/3599#discussion_r923248584
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/protocol/commands/ReconstructECContainersCommand.java:
##########
@@ -47,13 +48,8 @@ public ReconstructECContainersCommand(long containerID,
List<DatanodeDetailsAndReplicaIndex> sources,
List<DatanodeDetails> targetDatanodes, byte[] missingContainerIndexes,
ECReplicationConfig ecReplicationConfig) {
- super();
- this.containerID = containerID;
- this.sources = sources;
- this.targetDatanodes = targetDatanodes;
- this.missingContainerIndexes =
- Arrays.copyOf(missingContainerIndexes, missingContainerIndexes.length);
- this.ecReplicationConfig = ecReplicationConfig;
+ this(containerID, sources, targetDatanodes, missingContainerIndexes,
+ ecReplicationConfig, HddsIdFactory.getLongId());
}
// Should be called only for protobuf conversion
Review Comment:
Nit: comment seems to be outdated, as now it's called from the other
constructor.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ECUnderReplicationHandler.java:
##########
@@ -81,14 +81,17 @@ public ECUnderReplicationHandler(
* @param remainingMaintenanceRedundancy - represents that how many nodes go
* into maintenance.
* @return Returns the key value pair of destination dn where the command
gets
- * executed and the command itself.
+ * executed and the command itself. If an empty list if returned, it
indicates
Review Comment:
```suggestion
* executed and the command itself. If an empty list is returned, it
indicates
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/UnhealthyReplicationHandler.java:
##########
@@ -41,9 +42,13 @@ public interface UnhealthyReplicationHandler {
* @param remainingMaintenanceRedundancy - represents that how many nodes go
* into maintenance.
* @return Returns the key value pair of destination dn where the command
gets
- * executed and the command itself.
+ * executed and the command itself. If an empty list if returned, it
indicates
Review Comment:
```suggestion
* executed and the command itself. If an empty list is returned, it
indicates
```
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java:
##########
@@ -137,6 +138,7 @@ public class ReplicationManager implements SCMService {
private final ReentrantLock lock = new ReentrantLock();
private Queue<ContainerHealthResult.UnderReplicatedHealthResult>
underRepQueue;
+ private ECUnderReplicationHandler ecUnderReplicationHandler;
Review Comment:
Can be final?
```suggestion
private final ECUnderReplicationHandler ecUnderReplicationHandler;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
